Skip to content

Comments

Update coding-standards.yml#179

Merged
SimonMellerin merged 1 commit intomakinacorpus:mainfrom
Chris53897:patch-1
Jan 23, 2026
Merged

Update coding-standards.yml#179
SimonMellerin merged 1 commit intomakinacorpus:mainfrom
Chris53897:patch-1

Conversation

@Chris53897
Copy link
Contributor

No description provided.

@Chris53897 Chris53897 closed this Nov 1, 2025
@Chris53897 Chris53897 reopened this Nov 1, 2025
@pounard
Copy link
Member

pounard commented Jan 22, 2026

I would like very much to have some kind of discussions and politeness chattering whenever this kind of PR happens. But, I made the same change in another package and it's fine, I'm OK to merge it. ping @SimonMellerin

@SimonMellerin
Copy link
Member

I totally agree with @pounard , besides, FYI, we will soon update our contribution rules to make it mandatory to associate each PR with an issue.

Like this, we will prevent wide PR like this one and it will make our maintenance work much easier.

@SimonMellerin SimonMellerin merged commit 8cdec24 into makinacorpus:main Jan 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants