Add docker to example project #378
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The maintainer will decide, but I never saw docker files included in other 3rd-party Django apps. |
|
That's fair. This was just really frustrating to get to work. Maybe better to just add docker instructions? |
|
Thanks for the PR, though I agree with claudep, there isn't much sense in adding a Dockerfile in a Django app. Maybe this would be better located in the documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get the example project to run locally on my windows machine because of the GDAL dependancy. I created a docker container so that I could run the project. I've stripped it down to the bare minimum and put it in this PR. I thought this would be useful to include in light of #336, so others people could use it if they're also struggling.