Skip to content

Avoid defining withForms globally #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Avoid defining withForms globally #391

merged 1 commit into from
May 14, 2025

Conversation

pandafy
Copy link
Contributor

@pandafy pandafy commented Apr 22, 2025 •
edited
Loading

Fixes #389

@pandafy
Copy link
Contributor Author

pandafy commented Apr 23, 2025

@Gagaro can you please review this?

@nemesifier nemesifier mentioned this pull request May 8, 2025
Closed
nemesifier
nemesifier reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gagaro @adamchainz what do you think of this change?

adamchainz
adamchainz approved these changes May 10, 2025
View reviewed changes
Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good

@Gagaro
Copy link
Member

Gagaro commented May 14, 2025

Hi, sorry for the delay and thanks for the PR 👍 .

@Gagaro Gagaro merged commit a399630 into makinacorpus:master May 14, 2025
17 checks passed
@pandafy pandafy deleted the issues/384-withForms-redeclaration branch May 14, 2025 14:47
@nemesifier
Copy link
Contributor

Hi, sorry for the delay and thanks for the PR 👍 .

Thank you very much @Gagaro @adamchainz 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nemesifier nemesifier nemesifier left review comments

@adamchainz adamchainz adamchainz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JavaScript SyntaxError: redeclaration of const withForms

4 participants

@pandafy @Gagaro @nemesifier @adamchainz