-
Notifications
You must be signed in to change notification settings - Fork 21
Add configurable popups on markers #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 90.94% 91.97% +1.02%
==========================================
Files 33 33
Lines 2452 2479 +27
==========================================
+ Hits 2230 2280 +50
+ Misses 222 199 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
submarcos
reviewed
Oct 28, 2025
11 tasks
a7df4a9 to
a7c624e
Compare
submarcos
reviewed
Nov 5, 2025
submarcos
reviewed
Nov 5, 2025
Co-authored-by: Jean-Etienne Castagnede <[email protected]>
submarcos
reviewed
Nov 5, 2025
submarcos
reviewed
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds configurable popups on map markers.
Hover behavior remains unchanged - the object's name is still displayed on hover:
Click behavior now opens a popup displaying additional information and a button to navigate to the object's detail page. By default, the popup shows the object's name (if the model has a
namefield):Customization is available through the
LABEL_PER_MODELsetting. This allows you to configure which fields are displayed in the popup for each model (see documentation for setup details).LABEL_PER_MODELis a setting for applications using MapEntity, not a MapEntity setting itself.Example of a customized popup:
Fields specified in
LABEL_PER_MODELthat don't exist on the model or have empty values will be automatically excluded from the popup display.Related Issue