Merged
Conversation
PartyNell
requested review from
Chatewgne and
submarcos
and removed request for
Chatewgne
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 90.94% 91.97% +1.02%
==========================================
Files 33 33
Lines 2452 2479 +27
==========================================
+ Hits 2230 2280 +50
+ Misses 222 199 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
submarcos
reviewed
Oct 28, 2025
11 tasks
PartyNell
force-pushed
the
make_labels_configurable
branch
from
a7df4a9 to
a7c624e
Compare
submarcos
reviewed
Nov 5, 2025
submarcos
reviewed
Nov 5, 2025
Co-authored-by: Jean-Etienne Castagnede <j.e.castagnede@gmail.com>
submarcos
reviewed
Nov 5, 2025
submarcos
reviewed
Nov 5, 2025
PartyNell
added a commit
that referenced
this pull request
Jan 6, 2026
submarcos
added a commit
that referenced
this pull request
Jan 28, 2026
* change logout to POST in template (PR #322) * replace flake8 to ruff (PR #323) * minor fixes (PR #324) * Bump actions/checkout from 4 to 5 (PR #325) * Add locate control on map (PR #326) * replace flake8 to ruff (PR #323) - add test_app in the tested folders * Improve responsive design (PR #327) * Bump actions/setup-python from 5 to 6 (PR #328) * Add logo (PR #329) * Improve list : button, blocks and title (PR #332) * Upgrade datatables to v2 (PR #333) * Bump github/codeql-action from 3 to 4 (PR #334) * Fix tests with Faker (PR #336) * Add configurable popups on markers (PR #339) * Fix decorator to deal with extra view kwargs (PR #340) * Fix selected layers in screenshot (PR #341) * Fix get_expected_datatables_attrs content type in tests (PR #342) * Fix selected filters and overlays when coming back on list view (PR #343) * fix username factory to prevent multiple usages (PR #344) * Bump actions/checkout from 5 to 6 (PR #347) * Update changelogs * Update translations * Fix test_crud_status * Move mapentity_detail_pdf.css in templates * Fix the tooltip display when hovering over a feature * Fix highligh features on map when navigating in the list * Fix updateFromPks * Fix jumpTo behaviour * Add bulk actions (delete & edit) on list views / Fix batch deletion/update (PRs #348 & #352) * fix: duplicated translated fields when no layout (PR #351) * Fix map context * Display related fields as string representations in lists (PR #353) * Enhance responsive layout for multi-update form (PR #355) * add JavaScriptCatalog URL and script for i18n support * Fix geometries creation with geoman * Update geoman version to 0.6.1 * Update settings find location * Stop propagation of click event on layer to avoid fetching multiple time the same data * Listen layer event only on the manage layers in MapEntityObjectsLayer * Fix name search in list view (WARNING: if the interface is in a language and the name isn't define for this language it will not return information) * Fix filter button color * Translate map controllers tooltips * Add maxZoom setting for map * Migrate additionnal layers generation in MapEntity * Fix tooltip * Fix quality * Fix tests * remove leaflet dependency and related references (#357) * remove leaflet dependency and related references * Enhance geometry handling and error messaging in Maplibre integration * Enhance geometry handling and error messaging in Maplibre integration * Add demo settings and update Docker configuration for demo environment * Add PostgreSQL database configuration to demo settings * Add PostgreSQL database configuration to demo settings * Enable secure cookies for session and CSRF protection * Enable secure cookies for session and CSRF protection * Enable secure cookies for session and CSRF protection * Enable secure cookies for session and CSRF protection * Enable secure cookies for session and CSRF protection * Refactor code for consistency and readability * change bounds --------- Co-authored-by: J-E Castagnede <j.e.castagnede@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds configurable popups on map markers.
Hover behavior remains unchanged - the object's name is still displayed on hover:
Click behavior now opens a popup displaying additional information and a button to navigate to the object's detail page. By default, the popup shows the object's name (if the model has a
namefield):Customization is available through the
LABEL_PER_MODELsetting. This allows you to configure which fields are displayed in the popup for each model (see documentation for setup details).LABEL_PER_MODELis a setting for applications using MapEntity, not a MapEntity setting itself.Example of a customized popup:
Fields specified in
LABEL_PER_MODELthat don't exist on the model or have empty values will be automatically excluded from the popup display.Related Issue