Skip to content

Conversation

@PartyNell
Copy link
Contributor

Description

This PR adds configurable popups on map markers.

Hover behavior remains unchanged - the object's name is still displayed on hover:

Capture d'écran du 2025-10-28 08-35-46

Click behavior now opens a popup displaying additional information and a button to navigate to the object's detail page. By default, the popup shows the object's name (if the model has a name field):

Capture d'écran du 2025-10-28 08-36-08

Customization is available through the LABEL_PER_MODEL setting. This allows you to configure which fields are displayed in the popup for each model (see documentation for setup details).

⚠️ Note: LABEL_PER_MODEL is a setting for applications using MapEntity, not a MapEntity setting itself.

Example of a customized popup:

Capture d'écran du 2025-10-28 08-35-37

Fields specified in LABEL_PER_MODEL that don't exist on the model or have empty values will be automatically excluded from the popup display.

Related Issue

@PartyNell PartyNell requested review from Chatewgne and submarcos and removed request for Chatewgne October 28, 2025 07:57
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.97%. Comparing base (fdb4728) to head (62c9c22).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   90.94%   91.97%   +1.02%     
==========================================
  Files          33       33              
  Lines        2452     2479      +27     
==========================================
+ Hits         2230     2280      +50     
+ Misses        222      199      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PartyNell PartyNell changed the base branch from master to fix_test_content_type November 5, 2025 09:03
@PartyNell PartyNell force-pushed the make_labels_configurable branch from a7df4a9 to a7c624e Compare November 5, 2025 09:13
Base automatically changed from fix_test_content_type to master November 5, 2025 10:16
@PartyNell PartyNell merged commit bc97e15 into master Nov 13, 2025
13 checks passed
@PartyNell PartyNell deleted the make_labels_configurable branch November 13, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants