This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
QT6 and KF6 fixes #227
Closed
QT6 and KF6 fixes #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huantianad
force-pushed
the
master
branch
4 times, most recently
from
f8695ce
to
3c8efa6
Compare
huantianad
commented
Mar 18, 2024
| @@ -50,8 +50,8 @@ void CentralWidget::setupWebView() { | |||
| notification->setText(notificationInfo->message()); | |||
| notification->setPixmap( | |||
| QPixmap::fromImage(notificationInfo->icon())); | |||
| notification->setDefaultAction("View"); | |||
| connect(notification, &KNotification::defaultActivated, | |||
| notification->addDefaultAction("View"); | |||
There was a problem hiding this comment.
This gives a warning since it's nodiscard, is there a way I can use the result of this method instead of &KNotification::defaultActivated? I don't know how to cpp 😛
huantianad
commented
Mar 18, 2024
| target_link_libraries(discord-screenaudio KF5::GlobalAccel) | ||
| endif() | ||
|
|
||
| if(KF6Notifications_FOUND) | ||
| target_link_libraries(discord-screenaudio KF6::Notifications) | ||
| install(FILES assets/discord-screenaudio.notifyrc DESTINATION ${CMAKE_INSTALL_PREFIX}/share/knotifications6) |
There was a problem hiding this comment.
Should we use KDEInstallDirs?
|
Hey, thanks a lot. I have actually already started working on KF6 support in the kf6 branch, but I didn't have the time to finish working on that. I wasn't yet able to make my branch work on all combinations of Qt5/Qt6 and X11/Wayland. So when I find the time, I complete that and merge in potential changes you made. |
|
This has been added to the master branch a while ago. |
|
Yep, thanks! The nixpkgs package is building fine with the new KF6 packages 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing some of the issues I saw when trying to use the new kde framework packages when building. My code isn't the best nor I do know if this breaks QT5 support, but I'm putting this here in case you'd actually be interested in pursuing this.