Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Rerun pytest tests in case of failures #3769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Jan 24, 2025

Sporadic test failures due to reasons we cannot control (e.g. network) make an entire workflow fail.

This workflow need to be rerun manually, which takes extra time (up to 40 minutes) and distracts from work.

This proposes to automatically rerun test if they fail up to 3 times thanks to pytest-rerunfailures.

@jjerphan jjerphan added the release::ci_docs For PRs related to CI or documentation label Jan 24, 2025
@jjerphan jjerphan marked this pull request as ready for review January 24, 2025 09:31
@Hind-M
Copy link
Member

Hind-M commented Jan 24, 2025

As it may be very convenient to not restart failed tests manually, I don't think it's always due to network issues in our case. I guess this PR is opened due to the multiple recent tests failures that we are encountering, but in my opinion, we should rather investigate the root cause (as it seems to abort IIRC or terminate unexpectedly) and rerunning tests automatically after failure will prevent us from doing that thoroughly.

@JohanMabille
Copy link
Member

This could be done on the main branch once the PR has been merged though (I don't know if there is an easy way to do that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::ci_docs For PRs related to CI or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants