Skip to content

fix: Skip inaccessible CONDA_ENVS_DIRS #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025

Conversation

holzman
Copy link
Contributor

@holzman holzman commented Apr 9, 2025

Fixes #3848 as well as an adjacent bug if the parent directory is unreadable.

@holzman holzman force-pushed the skip-inaccesible-env-dir branch from 1fa49b3 to 9cb226c Compare April 9, 2025 21:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.86%. Comparing base (5bc7f9f) to head (9925716).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/api/configuration.cpp 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3887   +/-   ##
=======================================
  Coverage   63.86%   63.86%           
=======================================
  Files         300      300           
  Lines       38215    38220    +5     
  Branches     2852     2853    +1     
=======================================
+ Hits        24406    24411    +5     
  Misses      13742    13742           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Jun 11, 2025
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@holzman: can you confirm that the changes are still the ones you intended after the merge of main in?

@holzman
Copy link
Contributor Author

holzman commented Jun 11, 2025

Yes, LGTM

@jjerphan jjerphan merged commit 445bf87 into mamba-org:main Jun 11, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mamba crashes if env_dir is not readable
3 participants