Skip to content

Conversation

@holzman
Copy link
Contributor

@holzman holzman commented Apr 11, 2025

This code changes the rc file precedence to match the documentation and fixes a bug where if CONDARC or MAMBARC were set that it was ignoring all other configuration files.

This should solve #3126 (and maybe #2135 and possibly even #3841- I need to check).

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@e3ab63a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
libmamba/src/api/configuration.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3894   +/-   ##
=======================================
  Coverage        ?   63.70%           
=======================================
  Files           ?      301           
  Lines           ?    37550           
  Branches        ?     2796           
=======================================
  Hits            ?    23921           
  Misses          ?    13575           
  Partials        ?       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This code changes the rc file precedence to match the documentation
and fixes a bug where if CONDARC or MAMBARC were set that it was
ignoring all other configuration files.
@holzman holzman force-pushed the rcfile-precedence branch from cc0420f to 506b959 Compare May 14, 2025 18:38
@holzman holzman marked this pull request as ready for review May 14, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant