feat: Use ZDOTDIR if set and fallback to HOME #3933
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
approved these changes
Sep 19, 2025
AntoinePrv
requested changes
Sep 19, 2025
libmamba/src/core/shell_init.cpp
Outdated
| fs::u8path zshrc_path = home / ".zshrc"; | ||
| fs::u8path zshrc_path | ||
| // use ZDOTDIR if set and fallback to HOME | ||
| const char* zdotdir = std::getenv("ZDOTDIR"); |
There was a problem hiding this comment.
We have util::get_env to properly read from the environment.
libmamba/src/core/shell_init.cpp
Outdated
Comment on lines
1360
to
1368
| fs::u8path zshrc_path | ||
| // use ZDOTDIR if set and fallback to HOME | ||
| const char* zdotdir = std::getenv("ZDOTDIR"); | ||
| if (zdotdir != nullptr && zdotdir[0] != '\0') | ||
| { | ||
| zshrc_path = fs::u8path(zdotdir) / ".zshrc"; | ||
| } else { | ||
| zshrc_path = home / ".zshrc"; | ||
| } |
There was a problem hiding this comment.
Looks like the repeated logic could be factored into a simple function.
which return ZDOTDIR if set else HOME
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3933 +/- ##
=======================================
Coverage 64.14% 64.15%
=======================================
Files 303 303
Lines 38853 38870 +17
Branches 2883 2876 -7
=======================================
+ Hits 24923 24937 +14
- Misses 13863 13866 +3
Partials 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AntoinePrv
changed the title
github-actions
bot
added
the
release::enhancements
|
@AntoinePrv, do you have any pointers to fix the windows build and also the integration tests on UNIX platforms? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.