-
Notifications
You must be signed in to change notification settings - Fork 418
Remove spdlog from libmamba, provide libmamba-spdlog library
#4082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ca64ba1 to
c83e586
Compare
c83e586 to
2a12e45
Compare
…(used by libmambapy anb mamba/micromamba)
c2bc269 to
cbd6ef2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that one could create a PR on mamba-feedstock with the patch to anticipate packaging changes.
I agree, I'll take a look there. I will probably need your help with details @jjerphan 🙏🏽 |
Description
spdlogfromlibmambadependencies;libmamba-spdlogwhich provides the spdlog-basedLogHandlerfor mamba;libmambapyandmamba/micromambanow depends onlibmamba-spdlogto keep usingspdlogas a log handler;For simplicity,
libmamba-spdlogis a header-only library. This avoids many possible variations oflibmambausage to get in the way of easy packaging. As we always usespdlogas a header-only library and we just wrapps it, it shouldnt impact usage much. Also only end-user targets (usually executables) will need to decide whichLogHandlerto use so this header will probably only be compiled once.Notes:
libmamba-spdlog(next pr?);Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.