Skip to content

Conversation

@Klaim
Copy link
Member

@Klaim Klaim commented Oct 20, 2025

Description

  • removes spdlog from libmamba dependencies;
  • adds a new library libmamba-spdlog which provides the spdlog-based LogHandler for mamba;
  • libmambapy and mamba/micromamba now depends on libmamba-spdlog to keep using spdlog as a log handler;

For simplicity, libmamba-spdlog is a header-only library. This avoids many possible variations of libmamba usage to get in the way of easy packaging. As we always use spdlog as a header-only library and we just wrapps it, it shouldnt impact usage much. Also only end-user targets (usually executables) will need to decide which LogHandler to use so this header will probably only be compiled once.

Notes:

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the release::maintenance For PRs related to maintenance label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants