Remove spdlog from libmamba, provide libmamba-spdlog library
#4082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
spdlogfromlibmambadependencies;libmamba-spdlogwhich provides the spdlog-basedLogHandlerfor mamba;libmambapyandmamba/micromambanow depends onlibmamba-spdlogto keep usingspdlogas a log handler;For simplicity,
libmamba-spdlogis a header-only library. This avoids many possible variations oflibmambausage to get in the way of easy packaging. As we always usespdlogas a header-only library and we just wrapps it, it shouldnt impact usage much. Also only end-user targets (usually executables) will need to decide whichLogHandlerto use so this header will probably only be compiled once.Notes:
libmamba-spdlog(next pr?);Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.