Skip to content

Commit

Permalink
Update Arrow so that ArcticDB can be compiled with Clang 19 (#2134)
Browse files Browse the repository at this point in the history
#### Reference Issues/PRs
<!--Example: Fixes #1234. See also #3456.-->
Arrow is used only in the C++ tests to make sure that our custom Decimal
implementation matches Arrow's. Current version of Arrow is 14 but that
doesn't compile with Clang 19.
#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
  • Loading branch information
vasil-pashov authored Feb 5, 2025
1 parent 873ae6c commit 920391b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions cpp/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
],
"overrides": [
{ "name": "openssl", "version-string": "3.3.0" },
{ "name": "arrow", "version": "18.0.0" },
{ "name": "aws-sdk-cpp", "version": "1.11.474" },
{ "name": "azure-core-cpp", "version": "1.12.0" },
{ "name": "benchmark", "version": "1.9.0" },
Expand Down
2 changes: 1 addition & 1 deletion environment_unix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ dependencies:
- libiconv
- aws-c-s3
# Build dependencies for tests
- libarrow
- libarrow==18.0.0
# Python dependences
# Python 3.13+ is not yet supported
- python <3.13
Expand Down

0 comments on commit 920391b

Please sign in to comment.