Consolidate bindings for Enterprise ABI compatibility #2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoebusm
added
patch
phoebusm
changed the title
phoebusm
changed the title
phoebusm
requested review from
IvoDD,
alexowens90 and
poodlewars
as code owners
phoebusm
removed
the
no-release-notes
phoebusm
force-pushed
the
enterprise_abi_v2
branch
from
aaeb3f9 to
be18e9b
Compare
IvoDD
reviewed
Dec 29, 2025
| s3::S3Settings s3_settings(const pybind11::tuple& t); | ||
| pybind11::tuple to_tuple(const s3::GCPXMLSettings& settings); | ||
| pybind11::tuple to_tuple(const s3::S3Settings& settings); | ||
| void register_common_bindings(pybind11::module& m, bool local_bindings); |
Collaborator
There was a problem hiding this comment.
Nit: Maybe rename to register_common_storage_bindings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part of https://man312219.monday.com/boards/7852509418/pulses/18378732140 and
https://man312219.monday.com/boards/7852509418/pulses/8371158618
What does this implement or fix?
( Now
add_s3_library_to_envset both native config and class variable for configaws_authandaws_profile. They should only be set in native config. It can't be changed until7.0.0)Any other comments?
Checklist
Checklist for code changes...