Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghidra: Implement GhidraFeatureExtractor #1681

Merged
merged 35 commits into from
Aug 16, 2023
Merged

Ghidra: Implement GhidraFeatureExtractor #1681

merged 35 commits into from
Aug 16, 2023

Conversation

colton-gabertan
Copy link
Collaborator

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

Ghidra: Implement GhidraFeatureExtractor

Implements #49 : Ghidra Backend for capa

@colton-gabertan
Copy link
Collaborator Author

Note: before merging to backend-ghidra we need to merge the insn feature extractor into this one beforehand

@williballenthin williballenthin added ghidra Related to Ghidra integration gsoc Work related to Google Summer of Code project. labels Aug 7, 2023
mike-hunhoff
mike-hunhoff requested changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @colton-gabertan 🚀 - I've left comments for your review

capa/features/extractors/ghidra/extractor.py Show resolved Hide resolved
capa/features/extractors/ghidra/function.py Outdated Show resolved Hide resolved
capa/features/extractors/ghidra/helpers.py Outdated Show resolved Hide resolved
capa/features/extractors/ghidra/helpers.py Outdated Show resolved Hide resolved
capa/features/extractors/ghidra/insn.py Outdated Show resolved Hide resolved
capa/features/extractors/ghidra/insn.py Outdated Show resolved Hide resolved
capa/ghidra/helpers.py Outdated Show resolved Hide resolved
capa/ghidra/helpers.py Outdated Show resolved Hide resolved
capa/ghidra/helpers.py Outdated Show resolved Hide resolved
mike-hunhoff
mike-hunhoff requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! See comments about uni tests failing.

capa/main.py Show resolved Hide resolved
capa/main.py Show resolved Hide resolved
@colton-gabertan colton-gabertan merged commit b3cf112 into backend-ghidra Aug 16, 2023
17 checks passed
@colton-gabertan colton-gabertan deleted the ghidra-extractor-main branch August 16, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-hunhoff mike-hunhoff Awaiting requested review from mike-hunhoff

Assignees
No one assigned
Labels
ghidra Related to Ghidra integration gsoc Work related to Google Summer of Code project.
Projects
@colton-gabertan GSoC 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colton-gabertan @mike-hunhoff @williballenthin