record and show the analysis flavor #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
added
enhancement
williballenthin
commented
Aug 11, 2023
There was a problem hiding this comment.
i used the protobuf-compiler available on debian (versus nix or something else before) and it generates this python-native representation, which i like better than the opaque binary descriptors from before.
There was a problem hiding this comment.
kinda explodes the line-count, though
This was referenced Aug 11, 2023
mr-tz
reviewed
Aug 11, 2023
|
LGTM. thanks @williballenthin ! |
yelhamer
approved these changes
Aug 14, 2023
…into fix/issue-1711
williballenthin
merged commit d648fdf
into
dynamic-feature-extraction
7 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1711
please review and merge #1709 first
Checklist