elf: fix parsing of symtab from viv data #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
commented
Aug 14, 2023
williballenthin
commented
Aug 14, 2023
| def from_Elf(cls, ElfBinary) -> Optional["SymTab"]: | ||
| endian = "<" if ElfBinary.getEndian() == 0 else ">" | ||
| bitness = ElfBinary.bits | ||
| def from_viv(cls, elf: Elf.Elf) -> Optional["SymTab"]: |
There was a problem hiding this comment.
updated:
- name for consistency
- parameter name for pep8 (lowercase)
- type hint for mypy
|
The failing tests are relevant to the the symbol extraction. The I'll take a further look at this in a while. |
|
ah, good call that the tests are failing 🤦🏼 good thing we have those! tbh, i dont understand how the existing logic worked, except perhaps by random chance. i'll also dig into the failing tests and suggest further fixes. |
|
with 737fab7 tests are working for me again locally. |
|
awaiting for tests to pass in CI and then i'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1704
also cleans up naming and type hints
Checklist