web: change base url for capa Explorer Web #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
williballenthin
requested changes
Aug 9, 2024
web/explorer/vite.config.js
Outdated
| @@ -8,7 +8,7 @@ export default defineConfig(({ command, mode }) => { | |||
| const isBundle = mode === "bundle"; | |||
|
|
|||
| return { | |||
| base: isBundle ? "/" : "/capa/", | |||
| base: isBundle ? "/" : "/capa/explorer", | |||
There was a problem hiding this comment.
Suggested change
| base: isBundle ? "/" : "/capa/explorer", | |
| base: "./", |
I think this might do it.
via: https://stackoverflow.com/a/69746868
There was a problem hiding this comment.
this fix works.
tried it here: https://github.com/williballenthin/capa/blob/wb/webui-actions-1/web/explorer/vite.config.js
which now works here: https://williballenthin.github.io/capa/explorer/#/
There was a problem hiding this comment.
That works. The single page build npm run build:bundle remains the same as well.
There was a problem hiding this comment.
sweet, thanks for confirming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2266 (and #2262)
This PR changes the base url of capa Explorer Web to
/capa/explorerso that it can be hosted onmandiant.github.com/capa/explorerChecklist