Skip to content

web: fix build warnings #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williballenthin merged 2 commits into from
Aug 12, 2024
Merged

web: fix build warnings #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a6f7c7
web: remove unneeded import
fariss Aug 9, 2024
fcecbb8
web: fix code comments style
fariss Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/explorer/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" href="/public/favicon.ico" />
<link rel="icon" href="/favicon.ico" />
Copy link
Collaborator

@williballenthin williballenthin Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does vite rewrite these or is this also an absolute path that we should update?

Copy link
Collaborator Author

@fariss fariss Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is already the correct absolute path and does not need to be updated. Context.

<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Capa Explorer</title>
</head>
Expand Down
15 changes: 7 additions & 8 deletions web/explorer/src/components/columns/RuleColumn.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="cursor-default">
<!--- example node: "parse PE headers (2 matches) lib" --->
<!-- example node: "parse PE headers (2 matches) lib" -->
<template v-if="node.data.type === 'rule'">
<div>
<span>{{ node.data.name }}</span>
Expand All @@ -9,12 +9,12 @@
</div>
</template>

<!--- example node: "basic block @ 0x401000" or "explorer.exe" --->
<!-- example node: "basic block @ 0x401000" or "explorer.exe" -->
<template v-else-if="node.data.type === 'match location'">
<span class="text-sm font-italic">{{ node.data.name }}</span>
</template>

<!--- example node: "- or", "- and" --->
<!-- example node: "- or", "- and" -->
<template v-else-if="node.data.type === 'statement'"
>-
<span
Expand All @@ -27,7 +27,7 @@
</span>
</template>

<!--- example node: "- api: GetProcAddress", "- regex: .*\\.exe" --->
<!-- example node: "- api: GetProcAddress", "- regex: .*\\.exe" -->
<template v-else-if="node.data.type === 'feature'">
<span>
- {{ node.data.typeValue }}:
Expand All @@ -37,25 +37,24 @@
</span>
</template>

<!--- example node: "- malware.exe" (these are the captures (i.e. children nodes) of regex nodes) --->
<!-- example node: "- malware.exe" (these are the captures (i.e. children nodes) of regex nodes) -->
<template v-else-if="node.data.type === 'regex-capture'">
- <span class="text-green-700 font-monospace">{{ node.data.name }}</span>
</template>

<!--- example node: "exit(0) -> 0" (if the node type is call-info, we highlight node.data.name.callInfo) --->
<!-- example node: "exit(0) -> 0" (if the node type is call-info, we highlight node.data.name.callInfo) -->
<template v-else-if="node.data.type === 'call-info'">
<highlightjs lang="c" :code="node.data.name.callInfo" />
</template>

<!-- example node: " = IMAGE_NT_SIGNATURE (PE)" --->
<!-- example node: " = IMAGE_NT_SIGNATURE (PE)" -->
<span v-if="node.data.description" class="text-gray-500 text-sm" style="font-size: 90%">
= {{ node.data.description }}
</span>
</div>
</template>

<script setup>
import { defineProps } from "vue";
import LibraryTag from "@/components/misc/LibraryTag.vue";

defineProps({
Expand Down