Add Windows 10 NCSI response #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for this contribution! It seems reasonable to expect that this new file used by Windows 10 systems won't break FakeNet for Windows 7 or for Linux, so I'm open to fast-tracking this change without full regression testing. In your branch, can you please bump up the minor version number in the three files referenced in our documentation for Developing for FakeNet-NG? (Please also add a comment to the changelog similar to the ones already there, briefly describing the reason for the version change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows 10, the Network Connectivity Status Indicator is based on a request made to the following URL: http://www.msftconnecttest.com/connecttest.txt
This PR adds a valid response so that Windows 10 systems are considered connected to the Internet when using fakenet-ng.