Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the member variables for NexusException #39055

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Mar 13, 2025

The NXstatus is frequently not used or normally NX_ERROR. Also, nothing that processes the exception checked for the value of the status. This adds a member variable for the filename that the exception was created from. To aid in error processing.

Refs #38332 and EWM8451

To test:

The code should continue to compile and the error messages will be clearer. Manual review is sufficient.

This does not require release notes because it will be described at the end of the nexus work.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly label Mar 13, 2025
@peterfpeterson peterfpeterson added this to the Release 6.13 milestone Mar 13, 2025
@peterfpeterson peterfpeterson marked this pull request as ready for review March 13, 2025 20:31
@peterfpeterson peterfpeterson force-pushed the nexusexception branch 5 times, most recently from 4a67423 to f13198f Compare March 14, 2025 17:07
The NXstatus is frequently not used or normally NX_ERROR. This
adds a member variable for the filename that the exceptoin was
created from.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant