38668 Disable Unsupported Rietveld Refinement Method from Diffraction Interface

[JackEAllen]

Description of work

Summary of work

• Disable Rietveld Refinement Method within refinement_method_combobox on the GSAS-II tab in the Engineering and Diffraction Interface
• Add on-hover tooltip to state that Rietveld is not currently supported

Fixes #38668

To test:

• Open the Engineering Diffraction Interface Interfaces>>Diffraction>>Engineering Diffraction.
• Go to the Calibration tab, select Create New Calibration.
• For the Calibration Sample # enter 305738 and click the Calibrate button.
• On the Focus tab, enter Sample Run # 305761 and Vanadium # 307521 and click the Focus button.
• Change to the GSASII tab. The Instrument Group path should be pre-filled to a .prm file output by the calibration. and the Focused Data path should be pre-filled to the .gss file output from the Focus tab.
• Enter a name into the Project Name e.g. Test.
• For the Phase filepath, browse to MANTID_INSTALL_DIRECTORY/scripts/Engineering/ENGINX/phase_info/FE_GAMMA.cif.
• Try to select Rietveld from the dropdown selections in Refinement Method - Validate that you cannot select Rietveld and that it is greyed out as a selection option.
• Hover your curser over Rietveld in the Refinement Method dropdown selection and validate that the following message is displayed: "Rietveld is not currently supported."
• Select Pawley from the Refinement Method dropdown.
• Now, click Refine in GSAS II. After a few seconds, the output fit should be plotted.

---

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards?
• Are the unit tests small and test the class in isolation?
• If there is GUI work does it follow the GUI standards?
• If there are changes in the release notes then do they describe the changes appropriately?
• Do the release notes conform to the release notes guide?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?
• Do the changes handle unexpected situations, e.g. bad input?
• Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

[cailafinn]

Just a quick addition to the release notes. Otherwise (on macOS at least) the combobox option for Rietveld doesn't seem to be deactivated.

Disregard the above, it was due to a local pathing issue. Tested again and functionally this is working well.

Apologies this review took so long, it completely slipped off my list.

[cailafinn]

Works well when functionally tested; Unused option is now disabled. Code looks good to me. Nice work.