[@mantine/dates] TimePicker: Fix custom amPmLabels being truncated in… #8336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… input and dropdown (mantinedev#8312) Fixed an issue where custom AM/PM labels would be cut off both in the input field and dropdown list. The fix uses dynamic sizing for the AM/PM input field based on label length and allows dropdown controls to expand to fit their content.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8312
Changes
Input Field (
AmPmInput.tsx)sizeattribute based on the current value length (displayValue.length + 1)Dropdown Controls (
TimePicker.module.css).control: Changed from fixedwidth: 2.5emtomin-width: 2.5em+width: max-content.field[data-am-pm]: Changed from fixedwidth: calc(3ch + 0.3em)towidth: autosizeattribute