-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization for UI strings #11733
base: main
Are you sure you want to change the base?
Conversation
Personally, I use number-format for units. Not all locales follow the pattern of |
Few changes: - Use `ft` for feet (https://pt.wikipedia.org/wiki/P%C3%A9_(unidade)) - Use `feedback`, commonly used by other map providers. - Use common computer anglicisms (zoom, mouse scroll) - Do not gender Mapbox as there is not yet a consensus :-)
The effect of this PR on the bundle size: before
after
Compressed with:
|
…termeier and @DorkMatter) * Add localization for UI strings in Norwegian Co-authored-by: Barbara Flindt <[email protected]>
…lix-mittermeier) * Add localization for UI strings in Norwegian Bokmål
The German texts sound a bit strange. There are informal texts like "Finde …" or "Setze …" and formal texts like "Verwenden Sie …". I always try to avoid this decision by using words that don't need it (mostly infinitive). Here are my suggestions:
I'd also suggest changing these English texts:
|
Thanks for the contribution, @ygoe! @melanieimfeld, @kkaefer, what do you think of these suggestions? #11733 (comment)
|
Glad to see this is happening. I support a customer who does Indonesian and Transitional Chinese (HK, TW) which aren't in this PR. The translations we are using came from Lionbridge and differ a bit from those in this PR, not sure if you're interested in seeing those differences? |
Hi @andrewharvey, Yes, we already have PRs for Indonesian and Tranditional Chinese that needs to be verified, any contributions are welcome! Verifications are still needed for Czech, Greek, Indonesian, Georgian, Malay, Norwegian and Norwegian Bokmål, Slovak, Slovenian, Thai, and Traditional Chinese. |
…nwbsn, @minons1, and @ardiantovn) * Add localization for UI strings in Indonesian Co-authored-by: Salim <[email protected]> Co-authored-by: Christian Wibisono <[email protected]> Co-authored-by: ardiantovn <[email protected]>
* Add localization for UI strings in Czech * Update cs.js * Update cs.js
I wonder if "Improve this map" could also be translated? So far I haven't seen any option to achieve this. Is it possible? |
This PR adds translations for UI strings we use in GL JS into multiple languages.
AttributionControl.ToggleAttribution
English:
Toggle attribution
Context: Tooltip text on
AttributionControl
hoverAttributionControl.MapFeedback
English:
Map feedback
Context: Accessibility label for the
Improve this map
link in the expandedAttributionControl
. That label can be read by assistive technologyFullscreenControl.Enter
English:
Enter fullscreen
Context: Tooltip text on FullscreenControl hover when not in the fullscreen mode
FullscreenControl.Exit
English:
Exit fullscreen
Context: Tooltip text on
FullscreenControl
hover when in the fullscreen modeGeolocateControl.FindMyLocation
English:
Find my location
Context: Tooltip text on
GeolocateControl
hoverGeolocateControl.LocationNotAvailable
English:
Location not available
Context: Tooltip text on
GeolocateControl
hover when we can't locate userLogoControl.Title
English:
Mapbox logo
Context: Accessibility label for the Mapbox logo image. That label can be read by assistive technology
Map.Title
English:
Map
Context: Accessibility label for the map canvas element on the webpage. That label can be read by assistive technology
NavigationControl.ResetBearing
English:
Reset bearing to north
Context: Tooltip text on bearing button in
NavigationControl
NavigationControl.ZoomIn
English:
Zoom in
Context: Tooltip text on plus button in
NavigationControl
NavigationControl.ZoomOut
English:
Zoom out
Context: Tooltip text on minus button in
NavigationControl
ScrollZoomBlocker.CtrlMessage
English:
Use ctrl + scroll to zoom the map
Context: Text on map blocker alert when cooperative gestures are enabled
ScrollZoomBlocker.CmdMessage
English:
Use ⌘ + scroll to zoom the map
Context: Text on map blocker alert when cooperative gestures are enabled
TouchPanBlocker.Message
English:
Use two fingers to move the map
Context: Text on map blocker alert when cooperative gestures are enabled