Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow updating an image before it loads or fails to load. #12992

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Allow updating an image before it loads or fails to load. #12992

merged 1 commit into from
Dec 4, 2023

Conversation

stepankuzmin
Copy link
Contributor

@stepankuzmin stepankuzmin commented Dec 1, 2023 •
edited
Loading

Rebase of #12928. Allow updating an ImageSource image before loading or after it fails to load.

Closes #11725, #12928

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Write tests for all new functionality and make sure the CI checks pass.

@stepankuzmin stepankuzmin requested a review from a team as a code owner December 1, 2023 10:48
mourner
mourner approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but ideally rebase again so that @maciejmatu retains authorship of the commit.

@stepankuzmin stepankuzmin force-pushed the stepankuzmin/fix-update-image-before-load branch from d423a01 to ee4eded Compare December 4, 2023 09:08
@stepankuzmin stepankuzmin merged commit dd10457 into main Dec 4, 2023
28 checks passed
@stepankuzmin stepankuzmin deleted the stepankuzmin/fix-update-image-before-load branch December 4, 2023 09:30
@stepankuzmin stepankuzmin mentioned this pull request Dec 4, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

source.updateImage doesn't update image if first url is invalid
3 participants
@stepankuzmin @mourner @maciejmatu