Fix feature-dependent config expressions
#13453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brncsk
force-pushed
the
fix-feature-dependent-config
branch
from
67e617c to
8e54241
Compare
…nstants in `format` and `match` expressions
brncsk
force-pushed
the
fix-feature-dependent-config
branch
2 times, most recently
from
1c0aa2a to
cdb2c12
Compare
This exposes a `featureConstant` property on `Config` instances to determine at parse time whether the current value (or the default) of the config option evaluates to a feature-constant expression, and uses that property in `isFeatureConstant`.
brncsk
force-pushed
the
fix-feature-dependent-config
branch
from
8aab775 to
cca3291
Compare
brncsk
force-pushed
the
fix-feature-dependent-config
branch
from
631cb32 to
a1f8ba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #13452.
Some remarks:
A more roboust alternative to
typeEqualswould be to ensure that the type constants maintain their identity across thepostMessageboundary, but that would be a more involved refactor than what I could do.An alternative to the
featureConstantflag inConfigwould be to store the config expression itself in the instance, and defer toeachChildfor determining whether it's feature constant, however I'm not sure that'd work (can the value of a config option change between parsing and evaluating the["config"]expression)?Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.@mapbox/gl-nativeif this PR includes shader changes or needs a native port.