Fix qa test app crash #6320
Closed
Fix qa test app crash #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadsen
added
the
Android Auto
Codecov Report
@@ Coverage Diff @@
## main #6320 +/- ##
=========================================
Coverage 68.85% 68.85%
Complexity 4453 4453
=========================================
Files 668 668
Lines 26690 26690
Branches 3147 3147
=========================================
Hits 18378 18378
Misses 7104 7104
Partials 1208 1208 |
|
Closing in favor of #6316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as draft here because I just noticed this one #6316. Adding the release and debug dependencies may not fix CI/CD issues so will just leave this in case we want it.
Description
https://mapbox.atlassian.net/browse/NAVSDK-544
Because
libnavui-androidautocan use independent versions of thenav-sdk, changes to thenav-sdkcan cause binary incompatibilities when the function signatures change.This was a non-backwards compatible change to the
MapboxNavigationApp#6292. I added the@JvmStaticannotation for better java interop.I'm actually on the fence a little, to remove the
@JvmStaticfunction because when we add it now we'll have it forever (unless kotlin addresses it in some way https://issuetracker.google.com/issues/158393309)This pull request is following the direction that we want to keep
@JvmStatic. Android Auto can use the snapshot releases until2.8.0-rc.1is released.Related issues