Draft
Conversation
…LaneSnapshotTests` to `LaneViewSnapshotTests`.
MaximAlien
added
op-ex
MaximAlien
changed the base branch from
main
to
maxim/3974-fix-lane-view-styling
… on CarPlay for light and dark appearance.
MaximAlien
commented
Jun 30, 2022
| LaneView.appearance(for: phoneTraitCollection).secondaryColor = .defaultLaneArrowSecondary | ||
| LaneView.appearance(for: phoneTraitCollection).primaryColorHighlighted = .defaultLaneArrowPrimaryHighlighted | ||
| LaneView.appearance(for: phoneTraitCollection).secondaryColorHighlighted = .defaultLaneArrowSecondaryHighlighted | ||
| LaneView.appearance(for: phoneTraitCollection, whenContainedInInstancesOf: [LanesView.self]).primaryColor = .defaultLaneArrowPrimary |
Contributor
Author
There was a problem hiding this comment.
There is no need to set appearance for cases when LaneView is inside LanesView, because setting appearance for phoneTraitCollection covers this case.
MaximAlien
force-pushed
the
maxim/3974-fix-lane-view-styling
branch
2 times, most recently
from
215af69 to
6fed0a0
Compare
1ec5
reviewed
Jul 28, 2022
Comment on lines
337
to
338
| /// :nodoc: | ||
| open class LaneView: UIView { |
Contributor
There was a problem hiding this comment.
Thanks for documenting all the members of this class! Note that they still won’t show up in jazzy because the class itself is undocumented. I think that’s OK but just FYI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3972.
PR adds
LaneViewsnapshot tests to verify whether appearance styling colors are applied correctly for specific trait collections.