Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Xcode versions #4526

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Update Xcode versions #4526

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6c370b
Update Xcode versions
azarovalex Aug 10, 2023
ee97f49
explicitly specify macOS resource_class on CircleCI
azarovalex Aug 10, 2023
004274c
Disable codesign for simulator builds
azarovalex Aug 10, 2023
382988f
Additional CircleCI fixes
azarovalex Aug 10, 2023
8411fff
Use iOS 16.1 for snapshot tests
azarovalex Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 33 additions & 20 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ jobs:
default: "MapboxCoreNavigation"
macos:
xcode: << parameters.xcode >>
resource_class: macos.x86.medium.gen2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a required change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, without it resource_class defaults to medium with doesn't support anything newer than Xcode 14.2

environment:
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
Expand Down Expand Up @@ -406,7 +407,7 @@ jobs:
xcode: << parameters.xcode >>
- run:
name: MapboxCoreNavigation
command: xcodebuild -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=<< parameters.iOS >>,name=<< parameters.device >>' -project MapboxNavigation.xcodeproj -scheme << parameters.scheme >> -configuration << parameters.configuration >> <<# parameters.clean_build >>clean build <</ parameters.clean_build >><<# parameters.test >>test <</ parameters.test >> <<# parameters.codecoverage >>-enableCodeCoverage YES<</ parameters.codecoverage >> ENABLE_TESTABILITY=YES
command: xcodebuild -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=<< parameters.iOS >>,name=<< parameters.device >>' -project MapboxNavigation.xcodeproj -scheme << parameters.scheme >> -configuration << parameters.configuration >> <<# parameters.clean_build >>clean build <</ parameters.clean_build >><<# parameters.test >>test <</ parameters.test >> <<# parameters.codecoverage >>-enableCodeCoverage YES<</ parameters.codecoverage >> ENABLE_TESTABILITY=YES CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED="NO"
- when:
condition: << parameters.spm >>
steps:
Expand All @@ -418,7 +419,7 @@ jobs:
command: xcodebuild -resolvePackageDependencies
- run:
name: MapboxNavigation-Package
command: xcodebuild -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=<< parameters.iOS >>,name=<< parameters.device >>' -scheme MapboxNavigation-Package -configuration << parameters.configuration >> build <<# parameters.test >>test <</ parameters.test >> <<# parameters.codecoverage >>-enableCodeCoverage YES<</ parameters.codecoverage >> ENABLE_TESTABILITY=YES
command: xcodebuild -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=<< parameters.iOS >>,name=<< parameters.device >>' -scheme MapboxNavigation-Package -configuration << parameters.configuration >> build <<# parameters.test >>test <</ parameters.test >> <<# parameters.codecoverage >>-enableCodeCoverage YES<</ parameters.codecoverage >> ENABLE_TESTABILITY=YES CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED="NO"
# FIXME: SPM test host is currently disabled, but we should run tests on the SPM test host job. When it is reenabled, delete this section that generates the code coverage report.
- when:
condition: << parameters.codecoverage >>
Expand All @@ -443,12 +444,13 @@ jobs:
parameters:
xcode:
type: string
default: "13.3.1"
default: "14.3.1"
spm:
type: boolean
default: true
macos:
xcode: << parameters.xcode >>
resource_class: macos.x86.medium.gen2
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
Expand All @@ -458,7 +460,7 @@ jobs:
- *add-github-to-known-hosts
- run:
name: Build Example app
command: xcodebuild -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=15.4,name=iPhone 13 Pro Max' -project MapboxNavigation-SPM.xcodeproj -scheme Example clean build
command: xcodebuild -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=15.4,name=iPhone 13 Pro Max' -project MapboxNavigation-SPM.xcodeproj -scheme Example clean build CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED="NO"
- notify-build-finished

ios-trigger-metrics:
Expand All @@ -468,6 +470,7 @@ jobs:
default: "14.1.0"
macos:
xcode: << parameters.xcode >>
resource_class: macos.x86.medium.gen2
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
Expand All @@ -478,17 +481,18 @@ jobs:
parameters:
xcode:
type: string
default: "13.3.1"
default: "14.3.1"
device:
type: string
iOS:
type: string
default: "15.4"
default: "16.4"
notify_success:
type: boolean
default: false
macos:
xcode: << parameters.xcode >>
resource_class: macos.x86.medium.gen2
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
Expand All @@ -509,12 +513,12 @@ jobs:
parameters:
xcode:
type: string
default: "13.3.1"
default: "14.3.1"
device:
type: string
iOS:
type: string
default: "15.4"
default: "16.4"
notify_success:
type: boolean
default: false
Expand All @@ -523,7 +527,7 @@ jobs:
default: true
macos:
xcode: << parameters.xcode >>
resource_class: macos.x86.metal.gen1
resource_class: macos.x86.medium.gen2
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
Expand Down Expand Up @@ -568,6 +572,7 @@ jobs:
xcode: << parameters.xcode >>
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
resource_class: macos.x86.medium.gen2
steps:
- checkout
- when:
Expand Down Expand Up @@ -625,6 +630,7 @@ jobs:
xcode: 14.2.0
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
resource_class: macos.x86.medium.gen2
steps:
- checkout
- *add-github-to-known-hosts
Expand Down Expand Up @@ -655,18 +661,20 @@ jobs:

spm-core-integration-test-job:
macos:
xcode: "13.3.1"
xcode: "14.3.1"
resource_class: macos.x86.medium.gen2
steps:
- checkout
- *prepare-netrc-file
- *add-github-to-known-hosts
- run:
name: Build SPM Core integration test
command: cd Tests/SPMTest/CoreSPMTest && xcodebuild -scheme CoreSPMTest -destination "platform=iOS Simulator,OS=15.4,name=iPhone 13 Pro Max" build
command: cd Tests/SPMTest/CoreSPMTest && xcodebuild -scheme CoreSPMTest -destination "platform=iOS Simulator,OS=16.4,name=iPhone 13 Pro Max" build CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED="NO"

spm-ui-integration-test-job:
macos:
xcode: "14.1.0"
resource_class: macos.x86.medium.gen2
steps:
- checkout
- install-bash5
Expand All @@ -687,6 +695,7 @@ jobs:
xcode: << parameters.xcode >>
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
resource_class: macos.x86.medium.gen2
steps:
- checkout
- *restore-cache-gems
Expand Down Expand Up @@ -731,6 +740,7 @@ jobs:
xcode: << parameters.xcode >>
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
resource_class: macos.x86.medium.gen2
steps:
- checkout
- *restore-cache-gems
Expand Down Expand Up @@ -759,6 +769,7 @@ jobs:
xcode: << parameters.xcode >>
environment:
HOMEBREW_NO_AUTO_UPDATE: 1
resource_class: macos.x86.medium.gen2
steps:
- checkout
- *restore-cache-gems
Expand All @@ -781,6 +792,7 @@ jobs:
default: "14.1.0"
macos:
xcode: << parameters.xcode >>
resource_class: macos.x86.medium.gen2
steps:
- checkout
- install-mbx-ci
Expand All @@ -793,6 +805,7 @@ jobs:
default: "14.1.0"
macos:
xcode: << parameters.xcode >>
resource_class: macos.x86.medium.gen2
steps:
- checkout
- install-mbx-ci
Expand Down Expand Up @@ -853,17 +866,17 @@ workflows:
main-workflow:
jobs:
- build-job:
name: "Xcode_13.2.1_iOS_15.2_Debug"
xcode: "13.2.1"
iOS: "15.2"
device: "iPhone 13 Pro Max"
name: "Xcode_14.3.1_iOS_16.4_Debug"
xcode: "14.3.1"
iOS: "16.4"
device: "iPhone 14 Pro Max"
codecoverage: false
context: Slack Orb
- build-job:
name: "Xcode_13.3.1_iOS_15.4_SPM_Debug"
xcode: "13.3.1"
iOS: "15.4"
device: "iPhone 13 Pro Max"
name: "Xcode_14.1_iOS_16.1_SPM_Debug"
xcode: "14.1"
iOS: "16.1"
device: "iPhone 14 Pro Max"
spm: true
codecoverage: true
context: Slack Orb
Expand Down Expand Up @@ -916,7 +929,7 @@ workflows:
name: "Build Example"
context: Slack Orb
- spm-core-integration-test-job:
name: "Xcode 13.3; iOS 15.4; SPM Core test"
name: "Xcode 14.3.1; iOS 16.4; SPM Core test"
- build-job:
name: "Core integration test; Xcode 14.1; iOS 16.1"
xcode: "14.1.0"
Expand Down