-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct NavigationMatchOptions
congestion level in cycling profile …
#4564
Correct NavigationMatchOptions
congestion level in cycling profile …
#4564
Conversation
…4563) Correct the `.numericCongestionLevel` attribute to `.congestionLevel` when using the cycling profile. This is the same as #3495 (#3496) but for `NavigationMatchOptions` instead of `NavigationRouteOptions`. https://github.com/mapbox/mapbox-navigation-ios/blob/ff4873f77bd91505820e6027f1a4a43efc4a7a3d/Sources/MapboxCoreNavigation/NavigationRouteOptions.swift#L28-L34 Signed-off-by: Matt Robinson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4564 +/- ##
=======================================
Coverage 59.79% 59.79%
=======================================
Files 189 189
Lines 21216 21216
=======================================
Hits 12687 12687
Misses 8529 8529 |
I updated initial logic a bit based on Directions API documentation which states that both While this is technically a breaking change for custom profiles, because they'll no longer receive any congestion info, a proper way to receive congestions along the route in this case is to explicitly update |
@mattrobmattrob Hey Matt, thanks again for your contribution, I'm going the merge the current version, please take a look and let me know if you have any questions. I assume you don't need congestion levels for cycling profile, right? Officially Directions API don't support them and to be honest I'm not sure that this data even makes sense for cylcing profile. |
LGTM! Thank you. |
Briding changes from (#4563) to main.
Correct the
.numericCongestionLevel
attribute to.congestionLevel
when using the cycling profile. This is the same as #3495 (#3496) but forNavigationMatchOptions
instead ofNavigationRouteOptions
.mapbox-navigation-ios/Sources/MapboxCoreNavigation/NavigationRouteOptions.swift
Lines 28 to 34 in ff4873f