Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Polish by default in v2 samples #4698

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

kried
Copy link
Contributor

@kried kried commented Jul 25, 2024

Description

The Polish language was mistakenly set by default in the sample app for the v2 SDK in #4582

@kried kried self-assigned this Jul 25, 2024
@kried kried requested a review from a team as a code owner July 25, 2024 12:24
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.03%. Comparing base (af2a390) to head (8dfdd42).

Impacted file tree graph

@@            Coverage Diff             @@
##           lts/v2    #4698      +/-   ##
==========================================
- Coverage   60.03%   60.03%   -0.01%     
==========================================
  Files         189      189              
  Lines       21316    21316              
==========================================
- Hits        12798    12796       -2     
- Misses       8518     8520       +2     

see 1 file with indirect coverage changes

@kried kried merged commit 88b2109 into lts/v2 Jul 25, 2024
18 checks passed
@kried kried deleted the kried/reset-default-language-samples branch July 25, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants