Parse repeatx/repeaty from Image layers #324
Conversation
|
Thank you for your contribution! Please run rustfmt on it and I'll try to check it tomorrow morning |
aleokdev
left a comment
aleokdev
left a comment
There was a problem hiding this comment.
This seems to be breaking, so please base your changes against next instead. Thanks!
guysv
force-pushed
the
current
branch
2 times, most recently
from
15dd64e to
643294a
Compare
bjorn
left a comment
bjorn
left a comment
There was a problem hiding this comment.
Looks great to me. Now it's only missing an update to CHANGELOG.md. :-)
|
not sure bout the CI but my test pass 😬 |
|
The behavior of the include macro might've changed at some point, but it's okay, I'll see if I can fix it in another branch |
|
Oh yeah nevermind, it's this: #322 (comment) |
Really sorry about this. Could you rebase now? It should be fine after that. |
aleokdev
left a comment
aleokdev
left a comment
There was a problem hiding this comment.
LGTM, rebased and modified the changelog to fit our convention :)
|
@guysv There you go! |
|
thanks. sorry i didn't get to it! busy weekend |
|
Yes of course, don't worry about it, I just did it because I was already at it with the CI fixes and whatnot :) |
3 participants
This allows map renderers to respect the image layer repeatx/repeaty properties.
relates to adrien-bon/bevy_ecs_tiled#123