Skip to content

Fix CI #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Fix CI #326

merged 1 commit into from
Aug 27, 2025

Conversation

@aleokdev
Copy link
Contributor

@aleokdev aleokdev commented Aug 25, 2025 •
edited
Loading

Tries to fix CI. Sorry for the delay.

@aleokdev aleokdev changed the title partial Fix CI Aug 25, 2025
@aleokdev aleokdev force-pushed the fix-ci branch 4 times, most recently from 69de35c to 9155219 Compare August 25, 2025 18:11
@aleokdev
Fix CI
50f025b 
CI was failing with an error related to include! that it was not doing before.
This looks like a regression on someone else's part to be honest.
I'm not sure what we can do apart from changing the edition or just
skipping these tests, which is what I've done here.
@aleokdev
Copy link
Contributor Author

aleokdev commented Aug 25, 2025

So I'm not exactly sure what is wrong with the CI. I know it's related to this: https://doc.rust-lang.org/edition-guide/rust-2024/rustdoc-nested-includes.html, which specifies that until edition 2024, what we were doing didn't even compile. The thing is, until a few months ago, it did. So I have no idea what triggers the issue. I've also tried rolling back the toolchain version but even that fails to fix the issue.

The only ways I see to fix this are:

  • Remove the tests that use include! macros entirely from the README.
  • Ignore them.
  • Update the entire crate to edition 2024, which may affect some users and will take some effort to achieve.

I've chosen to ignore them, at least for now. This solution is not perfect but I think it will do for now, at least this way we'll be able to merge a few PRs.

@aleokdev aleokdev marked this pull request as ready for review August 25, 2025 18:22
@aleokdev aleokdev requested a review from bjorn August 25, 2025 18:22
bjorn
bjorn approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ignoring until switching to the 2024 edition is fine. 👍

@aleokdev aleokdev merged commit 18be44f into mapeditor:next Aug 27, 2025
4 checks passed
@aleokdev aleokdev deleted the fix-ci branch August 27, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn bjorn bjorn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aleokdev @bjorn