Fixed crash on macOS when JS code is JIT-compiled #4225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codesigned release did not have the right entitlement to be able to execute JIT-compiled code. Also, the MAP_JIT memory flag is only set by Qt since 6.8.2, so when Tiled is compiled against earlier Qt versions, we now force the use of the JS interpreter to disable the JIT compiler. TODO: This change relies on the Qbs codesign module (available since Qbs 1.19), which will likely need CI updates. Closes mapeditor#4218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codesigned release did not have the right entitlement to be able to execute JIT-compiled code.
Also, the MAP_JIT memory flag is only set by Qt since 6.8.2, so when Tiled is compiled against earlier Qt versions, we now force the use of the JS interpreter to disable the JIT compiler.
TODO: This change relies on the Qbs codesign module (available since Qbs 1.19), which will likely need CI updates.
Closes #4218