Fix issue with opening Tile Animation Editor #4264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, with Tiled compiled against Qt 6, the Tile Animation Editor would fail to become visible when it had been left in a maximized state before closing Tiled. Somehow the dialog in a maximized state was receiving WM_DESTROY when its parent QMainWindow was added to the layout in DocumentManager::setEditor: > External WM_DESTROY received for QWidgetWindow(0x20d997eba40, name="TileAnimationEditorWindow") , parent: QWindow(0x0) , transient parent: QWindow(0x0) I'm not entirely sure what causes this behavior, but I've found that lazily creating the TileAnimationEditor on the first time it is opened provided a workaround. Closes #4223
bjorn
force-pushed
the
fix-restore-tile-animation-editor
branch
from
a5edc73 to
66d6361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, with Tiled compiled against Qt 6, the Tile Animation Editor would fail to become visible when it had been left in a maximized state before closing Tiled.
Somehow the dialog in a maximized state was receiving WM_DESTROY when its parent QMainWindow was added to the layout in
DocumentManager::setEditor:
I'm not entirely sure what causes this behavior, but I've found that lazily creating the TileAnimationEditor on the first time it is opened provided a workaround.
Closes #4223