Add named properties on focus lost #4265
Merged
+31
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
When adding a new property or class member, losing the focus of the "add value widget" always aborted the addition. Now, it instead adds the property when a name had been entered. In this case, the value edit for the new property is not explicitly focused, to avoid disrupting the user's focus change. A few direct signal-to-signal connections were exchanged for lambdas to avoid the "focus" parameter getting set based on a "checked" parameter in the original signals.
bjorn
force-pushed
the
add-named-property-on-focus-lost
branch
from
8134994 to
2de50b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new property or class member, losing the focus of the "add value widget" always aborted the addition. Now, it instead adds the property when a name had been entered.
In this case, the value edit for the new property is not explicitly focused, to avoid disrupting the user's focus change.
A few direct signal-to-signal connections were exchanged for lambdas to avoid the "focus" parameter getting set based on a "checked" parameter in the original signals.