Skip to content

Use Node 22 to build frontend (instead of 18) #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

jake-low
Copy link
Contributor

@CollinBeczak CollinBeczak self-requested a review June 11, 2025 18:35
@CollinBeczak
Copy link
Contributor

Actually i did have a question about the 22-bullseye

@CollinBeczak
Copy link
Contributor

CollinBeczak commented Jun 11, 2025

You switched from bullseye to alpine in the maproulette3 repo, was curious if you remember why: https://github.com/maproulette/maproulette3/blob/784dc3081fe698f64520e10703969bc040989884/Dockerfile#L1

@jake-low
Copy link
Contributor Author

jake-low commented Jun 11, 2025

I tend to use Alpine as a base image for Dockerfiles I write because it's more minimal. Bullseye (Debian 11) is 50MB, while Alpine is <4MB. Apart from that there isn't much reason to prefer one over the other. However they use different package managers (Debian uses apt, Alpine uses apk) so switching this Dockerfile to use Alpine would also require changing the syntax of some of the later RUN commands.

Note that Bullseye is only being used for the builder image here; both Dockerfiles use an Alpine-based nginx image at runtime. So the difference really only affects how long it takes to pull the base image at build time (and hence affects how long CI runs take).

@CollinBeczak
Copy link
Contributor

ok cool, yeah this pr LGTM

@jake-low jake-low merged commit a3124cc into main Jun 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants