Skip to content

Fix bug raised by example notebooks #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025
Merged

Fix bug raised by example notebooks #565

merged 4 commits into from
Jun 3, 2025

Conversation

rwood-97
Copy link
Collaborator

Summary

Need to drop other geometry columns when running gdf.explore().
Should fix broken tests on https://github.com/maps-as-data/MapReader-examples

@rwood-97 rwood-97 added the no changelog For PRs which don't require changelog updates label May 28, 2025
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 77.89% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/spot_text/runner_base.py 80.76% <ø> (ø)
setup.py 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rwood-97 rwood-97 merged commit 87df72c into main Jun 3, 2025
9 checks passed
@rwood-97 rwood-97 deleted the fix-example-notebooks branch June 3, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog For PRs which don't require changelog updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant