Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3party] Restoring the server-side OSRM plugin. #14170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mpimenov
Copy link
Contributor

No description provided.

@tatiana-yan
Copy link
Contributor

а почему драфт?

#define ROUTING_SHORTCUTS_FILE_TAG "skoda"
#define ROUTING_CROSS_CONTEXT_TAG "chrysler"

#define ROUTING_FTSEG_FILE_TAG "ftseg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не используется

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

поэтому и драфт
сейчас оживлены части, которые нужны для компиляции, но на самом деле не нужны
например, неправильно оставлять в routing/ файлы, не добавленные в cmake

эта версия уже рабочая, но я ещё доделываю

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

понятно, спасибо

#define ROUTING_CROSS_CONTEXT_TAG "chrysler"

#define ROUTING_FTSEG_FILE_TAG "ftseg"
#define ROUTING_NODEIND_TO_FTSEGIND_FILE_TAG "node2ftseg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тоже не используется

эти define ещё нужны?

@@ -18,6 +20,17 @@
#include "../../../succinct/rs_bit_vector.hpp"
#include "../../../succinct/mapper.hpp"

#define ROUTING_MATRIX_FILE_TAG "mercedes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это такой вариант обфускации? это ещё нужно или можно назвать routing_matrix и так далее?

Copy link
Contributor

@tatiana-yan tatiana-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tatiana-yan tatiana-yan marked this pull request as ready for review July 16, 2021 12:14
@biodranik
Copy link
Contributor

@mpimenov а какую именно проблему задумывалось решить воскрешением OSRM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants