Add a gallery of tests to visually check for regressions#1064
Closed
Caerbannog wants to merge 3 commits intomaptiler:masterfrom
Closed
Add a gallery of tests to visually check for regressions#1064Caerbannog wants to merge 3 commits intomaptiler:masterfrom
Caerbannog wants to merge 3 commits intomaptiler:masterfrom
Conversation
Put zurich_switzerland.mbtiles in public/resources/gallery/ then run with: docker build . && docker run --rm -it -p 8080:8080 $(docker build -q .) -V \ --config /usr/src/app/public/resources/gallery/config.json URL on tileserver: http://0.0.0.0:8080/gallery/gallery.html Signed-off-by: Martin d'Allens <[email protected]>
Signed-off-by: Martin d'Allens <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Martin d'Allens <[email protected]>
Collaborator
|
I like the idea of this but I'm not about how it is being made its own page. This is similar to the maplibre-native render tests that get run as part of a github workflow. I would love to see something more like that where these image comparison tests could run in the workflow and use something like expect to compare the results, and then in the end have a report similar to the page you show that gets uploaded as part of the workflow. |
Collaborator
|
Closed in favor of #1792 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new page that shows a collection of tests, mostly static maps, and the expected outputs.
For static maps it show the difference and computes a success/failure.
The files are served from the /public directory.
A special config is used to allow remote images and test copyrights and watermarks.
It expects the usual zurich mbtiles, but does not download it automatically.
Instructions for use (also included)
Put zurich_switzerland.mbtiles in public/resources/gallery/ then run with:
docker build . && docker run --rm -it -p 8080:8080 $(docker build -q .) -V
--config /usr/src/app/public/resources/gallery/config.json
URL on tileserver: http://0.0.0.0:8080/gallery/gallery.html
Screenshot of the page