Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust root offsets for incremental measurements #567

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Apr 1, 2024

Depends on #564

@marc2332 marc2332 added the fix 🩹 Fixes a bug label Apr 1, 2024
@marc2332 marc2332 changed the base branch from main to fix/proper-state-equality-checks April 1, 2024 09:07
Copy link

github-actions bot commented Apr 1, 2024

Benchmark for 5669aeb

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 104.6±0.43ms 106.8±1.17ms +2.10%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.7±0.72ms 23.5±0.91ms -0.84%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1393.8±86.31µs 1399.1±42.59µs +0.38%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 132.1±1.85µs 129.4±1.74µs -2.04%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.6±0.22ms 23.7±0.40ms +0.42%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1646.9±31.41µs 1627.8±85.90µs -1.16%
benchmarks/size=19531 depth=7 wide=5 mode=cached 313.2±3.02µs 312.7±5.77µs -0.16%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.5±0.02ms 2.5±0.02ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 399.3±52.03µs 400.5±97.37µs +0.30%
benchmarks/size=54241 depth=5 wide=15 mode=cached 240.2±13.01µs 243.5±10.69µs +1.37%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.8±0.07ms 6.2±0.23ms -8.82%

Copy link

github-actions bot commented Apr 1, 2024

Benchmark for 5477dfe

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.3±0.32ms 106.0±1.87ms -0.28%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.7±1.68ms 27.2±1.63ms +10.12%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1411.6±16.49µs 1414.6±88.95µs +0.21%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 131.5±3.95µs 133.0±2.64µs +1.14%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.4±0.57ms 24.0±0.44ms -1.64%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1672.1±16.08µs 1662.0±126.95µs -0.60%
benchmarks/size=19531 depth=7 wide=5 mode=cached 319.4±5.11µs 315.4±4.84µs -1.25%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.5±0.02ms 2.6±0.08ms +4.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 412.5±37.56µs 394.9±2.26µs -4.27%
benchmarks/size=54241 depth=5 wide=15 mode=cached 260.2±17.79µs 265.2±29.45µs +1.92%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.4±0.33ms 6.2±0.15ms -3.13%

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.14%. Comparing base (270f409) to head (7c445bc).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           fix/proper-state-equality-checks     #567   +/-   ##
=================================================================
  Coverage                             73.14%   73.14%           
=================================================================
  Files                                   185      185           
  Lines                                 18604    18609    +5     
=================================================================
+ Hits                                  13607    13612    +5     
  Misses                                 4997     4997           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from fix/proper-state-equality-checks to main April 1, 2024 10:53
@marc2332 marc2332 merged commit 3cbc27b into main Apr 1, 2024
8 checks passed
@marc2332 marc2332 deleted the fix/adjust-root-measurement-offsets branch April 1, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant