Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the real text height for layout #932

Merged
merged 6 commits into from
Sep 28, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Sep 27, 2024

Otherwise some characters might get cut.

@marc2332 marc2332 added the fix 🩹 Fixes a bug label Sep 27, 2024
@marc2332 marc2332 added this to the 0.3.0 milestone Sep 27, 2024
@marc2332 marc2332 self-assigned this Sep 27, 2024
@marc2332 marc2332 marked this pull request as ready for review September 27, 2024 17:02
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (b4f05d4) to head (0448a3d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   75.83%   75.81%   -0.02%     
==========================================
  Files         207      207              
  Lines       23484    23483       -1     
==========================================
- Hits        17808    17803       -5     
- Misses       5676     5680       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review September 28, 2024 13:18
@marc2332 marc2332 merged commit 2531a94 into main Sep 28, 2024
3 of 4 checks passed
@marc2332 marc2332 deleted the fix/use-real-text-height-for-layout branch September 28, 2024 13:18
@marc2332 marc2332 restored the fix/use-real-text-height-for-layout branch October 3, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Fixes a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant