Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Split core render functions #937

Merged
merged 3 commits into from
Oct 6, 2024

Conversation

marc2332
Copy link
Owner

No description provided.

@marc2332 marc2332 added the internal impovement👍 Internal code improvements label Sep 28, 2024
@marc2332 marc2332 added this to the 0.3.0 milestone Sep 28, 2024
@marc2332
Copy link
Owner Author

wip

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 47.41573% with 234 lines in your changes missing coverage. Please review.

Project coverage is 75.20%. Comparing base (0cb934f) to head (d502b34).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/render/utils/paragraph.rs 32.88% 100 Missing ⚠️
crates/core/src/render/utils/borders.rs 70.21% 56 Missing ⚠️
crates/core/src/render/utils/shadows.rs 0.00% 50 Missing ⚠️
crates/state/src/values/fill.rs 0.00% 15 Missing ⚠️
crates/core/src/elements/rect.rs 8.33% 11 Missing ⚠️
crates/core/src/render/utils/label.rs 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   75.23%   75.20%   -0.03%     
==========================================
  Files         208      212       +4     
  Lines       24214    24223       +9     
==========================================
  Hits        18218    18218              
- Misses       5996     6005       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review October 6, 2024 08:30
@marc2332 marc2332 merged commit 1317488 into main Oct 6, 2024
9 checks passed
@marc2332 marc2332 deleted the refactor/split-core-render-functions branch October 6, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal impovement👍 Internal code improvements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant