[Code health] Remove Unicode Text from Source files (open-telemetry#2707

) Signed-off-by: perhapsmaple <[email protected]>
marcalff · Jun 20, 2024 · e1d9690 · e1d9690 · github-actions · Jun 20, 2024
1 parent aff26ac
commit e1d9690
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/api/include/opentelemetry/baggage/baggage.h b/api/include/opentelemetry/baggage/baggage.h
@@ -1,4 +1,4 @@
-// Copyright The OpenTelemetry Authors
+// Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
 #pragma once

diff --git a/api/include/opentelemetry/context/context.h b/api/include/opentelemetry/context/context.h
@@ -1,4 +1,4 @@
-// Copyright The OpenTelemetry Authors
+// Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
 #pragma once

diff --git a/api/include/opentelemetry/context/runtime_context.h b/api/include/opentelemetry/context/runtime_context.h
@@ -1,4 +1,4 @@
-// Copyright The OpenTelemetry Authors
+// Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
 #pragma once

diff --git a/ext/test/http/url_parser_test.cc b/ext/test/http/url_parser_test.cc
@@ -140,7 +140,8 @@ TEST(UrlDecoderTests, BasicTests)
   std::map<std::string, std::string> testdata{
       {"Authentication=Basic xxx", "Authentication=Basic xxx"},
       {"Authentication=Basic%20xxx", "Authentication=Basic xxx"},
-      {"%C3%B6%C3%A0%C2%A7%C3%96abcd%C3%84", "öà§ÖabcdÄ"},
+      {"%C3%B6%C3%A0%C2%A7%C3%96abcd%C3%84",
+       "\xc3\xb6\xc3\xa0\xc2\xa7\xc3\x96\x61\x62\x63\x64\xc3\x84"},
       {"%2x", "%2x"},
       {"%20", " "},
       {"text%2", "text%2"},

diff --git a/opentracing-shim/src/span_shim.cc b/opentracing-shim/src/span_shim.cc
@@ -111,7 +111,7 @@ void SpanShim::Log(opentracing::SystemTime timestamp,
 void SpanShim::logImpl(nostd::span<const EventEntry> fields,
                        const opentracing::SystemTime *const timestamp) noexcept
 {
-  // The Add Event’s name parameter MUST be the value with the event key
+  // The Add Event's name parameter MUST be the value with the event key
   // in the pair set, or else fallback to use the log literal string.
   const auto &event = std::find_if(fields.begin(), fields.end(),
                                    [](const EventEntry &item) { return item.first == "event"; });

diff --git a/sdk/test/metrics/instrument_metadata_validator_test.cc b/sdk/test/metrics/instrument_metadata_validator_test.cc
@@ -19,14 +19,14 @@ TEST(InstrumentMetadataValidator, TestName)
 {
   opentelemetry::sdk::metrics::InstrumentMetaDataValidator validator;
   std::vector<std::string> invalid_names = {
-      "",                               // empty string
-      "1sdf",                           // string starting with number
-      "123€AAA€BBB",                    // unicode characters
+      "",                                                             // empty string
+      "1sdf",                                                         // string starting with number
+      "\x31\x32\x33\xe2\x82\xac\x41\x41\x41\xe2\x82\xac\x42\x42\x42"  // unicode characters
       "/\\sdsd",                        // string starting with special character
       "***sSSs",                        // string starting with special character
       "a\\broken\\path",                // contains backward slash
       CreateVeryLargeString(25) + "X",  // total 256 characters
-      CreateVeryLargeString(26),        // string much bigger than 255 characters
+      CreateVeryLargeString(26),        // string much bigger than 255 character
   };
   for (auto const &str : invalid_names)
   {
@@ -56,7 +56,7 @@ TEST(InstrumentMetadataValidator, TestUnit)
   std::vector<std::string> invalid_units = {
       CreateVeryLargeString(5) + "ABCERTYGJ",  // total 64 charactes
       CreateVeryLargeString(7),                // string bigger than 63 chars
-      "123€AAA€BBB",                           // unicode string
+      "\x31\x32\x33\xe2\x82\xac\x41\x41\x41\xe2\x82\xac\x42\x42\x42",  // unicode string
   };
   for (auto const &str : invalid_units)
   {
Benchmark suite	Current: `e1d9690`	Previous: `05bfb8a`	Ratio
`BM_SpinLockThrashing/1/process_time/real_time`	`0.198371075674814` ms/iter	`0.09259766044051312` ms/iter	`2.14`
`BM_SpinLockThrashing/2/process_time/real_time`	`0.43039524091848635` ms/iter	`0.20281761740716758` ms/iter	`2.12`
`BM_SpinLockThrashing/4/process_time/real_time`	`1.4883858816964286` ms/iter	`0.722050666809082` ms/iter	`2.06`
`BM_ProcYieldSpinLockThrashing/2/process_time/real_time`	`1.301112174987793` ms/iter	`0.2146412700002644` ms/iter	`6.06`
`BM_ProcYieldSpinLockThrashing/4/process_time/real_time`	`1.9236397743225098` ms/iter	`0.7166242424821679` ms/iter	`2.68`
`BM_NaiveSpinLockThrashing/4/process_time/real_time`	`1.4681673049926758` ms/iter	`0.5747613547736132` ms/iter	`2.55`