Http support

[jamesalbert]

Just want to say I've had a lot of fun with gravity 😄

I created an issue #280 about adding http support. I'm still unsure if this is wanted at this point in the project. With feedback, I'd be happy to refactor this janky pr a bit and implement the rest for an mvp. Or you can tell me my code sucks and to go home.

I've been testing using a basic flask server and the following gravity script:

func main() {
    var get_tests = [
        [
            "host": "https://reddit.com"
        ],
        [
            "host": "https://api.github.com",
            "path": "/users/jamesalbert"
        ],
        [
            "host": "https://httpbin.org",
            "path": "/get"
        ]
    ]

    get_tests.loop(func (request) {
        var resp = Http.get(request)
        System.print("=== " + resp.Hostname)
        System.print(resp)
    })

    var post_tests = [
        [
            "host": "https://httpbin.org/post",
            "path": "/post",
            "data": [
                "pet": "cat"
            ]
        ]
    ]

    post_tests.loop(func (request) {
        var resp = Http.post(request)
        System.print("=== " + resp.Hostname)
        System.print(resp)
    })
}

[jamesalbert]

this was needed to concat, unsure of the consequences

[marcobambini]

Please check my reviews

[marcobambini]

gravity_hash_dup would probably be a better name

[marcobambini]

Why not to reuse convert_map2string defined in gravity_core.c?

[marcobambini]

Not sure to understand the use case of this...

[jamesalbert]

@marcobambini Wouldn't you say there's a need for _to_value functions for all types? E.g. if I want to create a map with a key associated to an array, I'd have no way of doing that without doing something like:

gravity_map_t *response = gravity_map_new(vm, 32);
gravity_list_t *headers = gravity_list_new(vm, 32);
gravity_map_insert(vm, response,
    gravity_string_to_value("Headers"),
    gravity_list_to_value(headers));

If there's a way for already doing something like this, let me know. I'm cleaning up the implementation at the moment, currently trying to get something like this going

[jamesalbert]

I use the map_to_value method in a similar fashion in src/optionals/gravity_http.c

[jamesalbert]

Oh I guess VALUE_FROM_OBJECT might be helpful in this case 😎

[marcobambini]

obj->len would be much better than strlen(obj->s)

[marcobambini]

Instead of always perform a men_realloc you should first check if (obj->alloc - obj->len) is big enough

[marcobambini]

memcpy would be faster (you already have the right pointer by using (obj->s + obj->len)

[marcobambini]

Thanks @jamesalbert for your work on Gravity!

[jamesalbert]

Awesome @marcobambini I'll try and tackle these after work. Np, it's a nice little language, I like the style

[marcobambini]

Thanks @jamesalbert and please note that a unit test would be recommended.

[jamesalbert]

@marcobambini I figured an http client without ssl support is pretty useless. I added openssl support and tried to make it as non-dependent as possible. If the user doesn't have openssl, they can set the optional make parameter OPENSSL_ENABLED to false. I only have my macbook (with openssl) to my disposal, so I added some docker to build and run the example (1 container with openssl, 1 without). All 3 environments are building for me, but I'm sure there's more we can do.

Let me know what you think. You can run the examples in docker with make docker

[marcobambini]

@jamesalbert I apologize for taking so long in reviewing your pull request but I made a lot of refactoring for optional classes. Can you please remove the files:
gravity_visualstudio/gravity.vcxproj
gravity_visualstudio/gravity.vcxproj.filters
so I can fix the remaining conflicts and merge your pull request?
Thanks a lot.

[hggz]

@marcobambini not sure if this is still possible to be revisited. would it be possible to carry this work through with this pr's changes, if it currently isnt in the main release?