Fix bug with overriding options object #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, with the addition of supporting running LSP as a standalone process, the `connect` function was changed. This changed the promise such that the options object was now the result of the `connection.onInitialized` function rather than the result of the callback from `connection.onInitialize`, which seems like an error in understanding the API of the LSP library This reverts that change, but still returns the value options out of the promise, though it is likely an uneeded change. Automated testing for this would be ideal, but as there doesn't seem to be any infrastructure for that currently, that is out of scope of this commit
Contributor
Author
|
For more context on this change, see markdoc/markdoc#500 |
|
Not sure if this is related, but the latest version is not working for me in vscode (I'm on wsl). |
|
No intent to spam but the extension (as is currently on the VSCode Marketplace) doesn't work at all (in sense of schema). |
segphault
approved these changes
Apr 28, 2024
Contributor
segphault
left a comment
segphault
left a comment
There was a problem hiding this comment.
Really sorry for the delay on this. Thanks for the fix!
Contributor
|
I'll bump the version numbers and push a new release to the marketplace with this fix shortly |
It's not working for me now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, with the addition of supporting running LSP as a standalone process, the
connectfunction was changed.This changed the promise such that the options object was now the result of the
connection.onInitializedfunction rather than the result of the callback fromconnection.onInitialize, which seems like an error in understanding the API of the LSP libraryThis reverts that change, but still returns the value options out of the promise, though it is likely an uneeded change.
Automated testing for this would be ideal, but as there doesn't seem to be any infrastructure for that currently, that is out of scope of this commit