BREAKING CHANGE: Move all regexes to rules #3519
Open
+152
−97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 14.1.3
Description
Move all regular expressions to rules.ts to be able to reuse similar regular expressions and spped up marked by creating the regular expressions once instead of inside a loop like the tokenizer or parser loops. These rules will be in an object exported as
other
by rules.ts.Contributor
Committer
In most cases, this should be a different person than the contributor.