-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flesh out handling of Updates #13
Open
ghost
wants to merge
3
commits into
markolson:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,36 @@ | ||
module Kickscraper | ||
class Update < Api | ||
|
||
attr_accessor :sequence, :title, :body | ||
|
||
def to_s | ||
"Update \##{sequence}: #{title}" | ||
end | ||
|
||
def inspect | ||
"<Update: '#{title}'>" | ||
end | ||
|
||
def reload! | ||
# The API URL must be specified here as api['update'], because api.update refers to the | ||
# update method inherited from Hashie | ||
@raw = Kickscraper.client.process_api_url("Update", self.urls.api['update'], false) | ||
Kickscraper::Update::do_coercion(self) | ||
end | ||
|
||
def sequence | ||
reload! unless @raw['sequence'] | ||
@raw['sequence'] | ||
end | ||
|
||
def title | ||
reload! unless @raw['title'] | ||
@raw['title'] | ||
end | ||
|
||
def body | ||
reload! unless @raw['body'] | ||
@raw['body'] | ||
end | ||
|
||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
describe Kickscraper::Update do | ||
let(:client) { Kickscraper.client } | ||
subject(:update) { client.find_project(TEST_PROJECT_ID).updates.first } | ||
|
||
context "loads basic update information" do | ||
its(:id) { should be > 0 } | ||
its(:project_id) { should be > 0 } | ||
its(:sequence) { should be > 0 } | ||
its(:public) { should satisfy { |s| [true,false].include?(s) } } | ||
its(:visible) { should satisfy { |s| [true,false].include?(s) } } | ||
its(:title) { should_not be_empty } | ||
its(:published_at) { should be >= 1262304000 } | ||
its(:updated_at) { should be >= 1262304000 } | ||
its(:comments_count) { should be >= 0 } | ||
its(:likes_count) { should be >= 0 } | ||
end | ||
|
||
context "reloads" do | ||
before { update.reload! } | ||
|
||
its(:sequence) { should be > 0 } | ||
its(:title) { should_not be_empty } | ||
end | ||
|
||
context "loads additional information for a visible update" do | ||
# Ensure that this test runs on a public update, so its success does not | ||
# depend on the user running the tests | ||
subject { client.process_api_url("update", TEST_PUBLIC_UPDATE_URL) } | ||
|
||
its(:body) { should_not be_empty } | ||
its(:images) { should have_at_least(0).items } | ||
its(:sounds) { should have_at_least(0).items } | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just looking at this right now. I'm wondering if this test is actually passing for the wrong reason. If TEST_PROJECT_ID is a valid project, why is subject nil on the next line?
Maybe the subject should be in a context block, and it should search for an invalid project id?