-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow binding to IPv6 (if present) #601
base: master
Are you sure you want to change the base?
Conversation
If an interface has an IPv6 address record associated with it then, and only then, prefer that. Otherwise AF_INET is used (Ipv4 address)
Need to probably do |
This reverts commit 18c2a38.
Okay, all prepped. Need to figure out why the test failing tho :), doesn't seem to be related to the other PR me thinks. |
@markqvist Not sure why but a unittest fails |
Reverted changes to see if CI passes, looks like it didn't. I am even more Added changes back anyways. |
Nvm it is passing |
Should be good to merge @markqvist |
Hi everyone, I've noticed that
Am I understanding this correctly? If so, I have some concerns about merging this. It seems to change the behavior of an existing configuration option in an unexpected way, which could potentially break many existing setups. For instance, consider a case where someone binds to an interface with both a public IPv4 and an IPv6 address, but the IPv6 address isn't actually usable for internet connectivity. In fact, I believe the current behavior of the From my perspective, there are a few key issues here that could be improved:
I would really appreciate @markqvist’s thoughts on this since he’s the project maintainer. If he agrees and you, @deavmi, don’t plan to implement these changes, I’d be happy to take this on myself and submit a PR. Thanks! |
Agreed, listening on all associated IP addresses (of both families) would be ideal and also what I would like. |
If an interface has an IPv6 address record associated with it then, and only then, prefer that.
Otherwise AF_INET is used (Ipv4 address)
get_address_for_if(string)
doneget_broadcast_for_if(string)