Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Data race + Warning #826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aiFigueiredo
Copy link

@aiFigueiredo aiFigueiredo commented Dec 19, 2024

This PR aims to address #825

What was done:

  1. Added unit tests while on master to cover any possible outcomes of ParseManager.parseMultiple including a measure test.
  2. Addressed the warning by removing DispatchQueue.concurrentPerform
  3. Committed the baseline plists (set while on master writing the tests). Let me know if that shouldn't be committed.

Notes:

  1. Checked test run times and it seems this approach takes less time to complete:

Screenshot 2024-12-19 at 19 23 23
Screenshot 2024-12-19 at 19 23 34
(used the existing test as a baseline)

  1. This approach drops DispatchQueue.concurrentPerform but maybe that is not something that should be done?
  2. An alternate approach to fixing the data race could be a lock. Let me know if that is preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant