#223 - allow for custom registrations #224
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentledepp
force-pushed
the
feature/223_customresgistration
branch
from
bfa6bb2 to
7dded57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my first try to implement #223.
This only handles
INotificationHandler<>registrations.You can register your
INotificationHandler<>asservices.AddXY<INotificationHandler<N>,MyNotificationHandler>services.AddXY<INotificationHandler<N>>(new MyNotificationHandler())services.AddXY<INotificationHandler<N>>(_ => new MyNotificationHandler())The reason is, that by having the
ServiceDescriptorwith theImplementationFactory, I have no way to find out the concreat implementation type.Now the same way, this could be implemented for the other handlers too.
What do you think? @martinothamar @janoveh
Shall I provide a PR?