Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic input switching #13

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Enable dynamic input switching #13

merged 1 commit into from
Nov 11, 2018

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Oct 29, 2018

The blueprints part to enable dynamic input switching. For the whose view, please visit the issue Enable dynamic input switching.

Copy link
Member

@pdsouza pdsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pdsouza
Copy link
Member

pdsouza commented Oct 29, 2018

This looks good to me.

One nitpick: I think we can improve the enable and disable scripts slightly by using some shell scripting best practices like making sure to add the "#!/bin/sh" or "#!/bin/bash" header depending on which shell features are needed, double-quote all variable expansions to avoid potential word splitting, etc. But if you have tested it works, then it's fine. I can improve the scripts later.

@pdsouza
Copy link
Member

pdsouza commented Oct 29, 2018

One question: what's the size of the final rootfs image after adding xinput as a dependency?

Add scripts to enable/disable input based on xinput. The lxc
will use attach to execute those scripts to enable/disable input
of Linux based on Android's logic of dynamic input switching.

Signed-off-by: utzcoz <[email protected]>
@utzcoz
Copy link
Member Author

utzcoz commented Nov 1, 2018

@pdsouza I have added "#!/bin/bash" for all scripts. The final desktop image's size with xinput is 224MB.

@pdsouza
Copy link
Member

pdsouza commented Nov 3, 2018

@utzcoz Great, that should be good. I was asking because on some of our older devices, space on /system is very limited. Thanks.

@pdsouza pdsouza merged commit a49b4c1 into maruos:master Nov 11, 2018
@pdsouza
Copy link
Member

pdsouza commented Nov 11, 2018

@utzcoz Merged!

@utzcoz utzcoz deleted the enable-dynamic-input-switching branch November 11, 2018 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants